optimize transaction filter

This commit is contained in:
mirrerror
2023-11-28 19:38:10 +02:00
parent ee8a61ba8b
commit 5a8a8f1197

View File

@@ -17,14 +17,13 @@ public class TransactionFilter {
private final CredentialService credentialService;
public List<? extends IMoneyTransaction> filterByEmail(List<? extends IMoneyTransaction> transactions, String email) {
return transactions
.stream()
.filter(transaction -> {
Optional<Credential> credential = credentialService.findByEmail(email);
if(credential.isEmpty())
throw new UserNotFoundException("The user has not been found");
return credential.get().getUser().equals(transaction.getUser());
})
return transactions
.stream()
.filter(transaction -> credential.get().getUser().equals(transaction.getUser()))
.toList();
}