From 5a8a8f11973bbb0f0718ad01db2c86be3052437a Mon Sep 17 00:00:00 2001
From: mirrerror <cayote20@mail.ru>
Date: Tue, 28 Nov 2023 19:38:10 +0200
Subject: [PATCH] optimize transaction filter

---
 .../expensetrackerfaf/util/TransactionFilter.java     | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/main/java/com/faf223/expensetrackerfaf/util/TransactionFilter.java b/src/main/java/com/faf223/expensetrackerfaf/util/TransactionFilter.java
index f6380b5..1c2a57f 100644
--- a/src/main/java/com/faf223/expensetrackerfaf/util/TransactionFilter.java
+++ b/src/main/java/com/faf223/expensetrackerfaf/util/TransactionFilter.java
@@ -17,14 +17,13 @@ public class TransactionFilter {
     private final CredentialService credentialService;
 
     public List<? extends IMoneyTransaction> filterByEmail(List<? extends IMoneyTransaction> transactions, String email) {
+        Optional<Credential> credential = credentialService.findByEmail(email);
+        if(credential.isEmpty())
+            throw new UserNotFoundException("The user has not been found");
+
         return transactions
                 .stream()
-                .filter(transaction -> {
-                    Optional<Credential> credential = credentialService.findByEmail(email);
-                    if(credential.isEmpty())
-                        throw new UserNotFoundException("The user has not been found");
-                    return credential.get().getUser().equals(transaction.getUser());
-                })
+                .filter(transaction -> credential.get().getUser().equals(transaction.getUser()))
                 .toList();
     }