Tiny code clean-ups

This commit is contained in:
2023-09-30 00:14:07 +03:00
parent 2e72a64815
commit d85f9a6132
18 changed files with 25 additions and 92 deletions

View File

@@ -15,11 +15,8 @@ public class Faculty implements Serializable {
} }
private String name; private String name;
private String abbreviation; private String abbreviation;
private final List<Group> groups = new ArrayList<>();
private List<Group> groups = new ArrayList<>();
private StudyField field; private StudyField field;
public void addGroup(Group group) { public void addGroup(Group group) {

View File

@@ -6,6 +6,7 @@ import java.io.Serializable;
public class Grade implements Serializable { public class Grade implements Serializable {
private final Subjects subject; private final Subjects subject;
private final int grade; private final int grade;
public Grade(Subjects subject, int grade) { public Grade(Subjects subject, int grade) {

View File

@@ -1,7 +1,3 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui; package org.lumijiez.gui;
import org.lumijiez.data.DataDeserializer; import org.lumijiez.data.DataDeserializer;

View File

@@ -1,12 +1,7 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.faculty; package org.lumijiez.gui.forms.faculty;
import org.lumijiez.base.Faculty; import org.lumijiez.base.Faculty;
import org.lumijiez.enums.StudyField; import org.lumijiez.enums.StudyField;
import org.lumijiez.gui.StudentManagementGUI;
import org.lumijiez.gui.util.ComponentDecorator; import org.lumijiez.gui.util.ComponentDecorator;
import org.lumijiez.gui.util.DisplayerManager; import org.lumijiez.gui.util.DisplayerManager;
import org.lumijiez.managers.Supervisor; import org.lumijiez.managers.Supervisor;
@@ -40,7 +35,8 @@ public class EditFacultyForm extends JFrame {
setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18)); // NOI18N titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18));
titleLabel.setText("Edit a faculty"); titleLabel.setText("Edit a faculty");
submitButton.setText("Submit"); submitButton.setText("Submit");
cancelButton.setText("Cancel"); cancelButton.setText("Cancel");

View File

@@ -1,11 +1,6 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.faculty; package org.lumijiez.gui.forms.faculty;
import org.lumijiez.base.Faculty; import org.lumijiez.base.Faculty;
import org.lumijiez.gui.StudentManagementGUI;
import org.lumijiez.gui.util.ComponentDecorator; import org.lumijiez.gui.util.ComponentDecorator;
import org.lumijiez.gui.util.DisplayerManager; import org.lumijiez.gui.util.DisplayerManager;
import org.lumijiez.managers.Supervisor; import org.lumijiez.managers.Supervisor;
@@ -34,7 +29,7 @@ public class RemoveFacultyForm extends JFrame {
setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18)); // NOI18N titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18));
titleLabel.setText("Remove a faculty"); titleLabel.setText("Remove a faculty");
submitButton.setText("Submit"); submitButton.setText("Submit");

View File

@@ -1,7 +1,3 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.faculty; package org.lumijiez.gui.forms.faculty;
import org.lumijiez.base.Faculty; import org.lumijiez.base.Faculty;
@@ -33,7 +29,7 @@ public class ShowFacultyForm extends JFrame {
setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18)); // NOI18N titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18));
titleLabel.setText("Show a faculty"); titleLabel.setText("Show a faculty");
submitButton.setText("Submit"); submitButton.setText("Submit");

View File

@@ -1,7 +1,3 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.group; package org.lumijiez.gui.forms.group;
import org.lumijiez.base.Faculty; import org.lumijiez.base.Faculty;
@@ -36,7 +32,7 @@ public class AddGroupForm extends JFrame {
setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18)); // NOI18N titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18));
titleLabel.setText("Add a new group"); titleLabel.setText("Add a new group");
nameField.setText("Name..."); nameField.setText("Name...");

View File

@@ -1,11 +1,6 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.group; package org.lumijiez.gui.forms.group;
import org.lumijiez.base.Group; import org.lumijiez.base.Group;
import org.lumijiez.gui.StudentManagementGUI;
import org.lumijiez.gui.util.ComponentDecorator; import org.lumijiez.gui.util.ComponentDecorator;
import org.lumijiez.gui.util.DisplayerManager; import org.lumijiez.gui.util.DisplayerManager;
import org.lumijiez.managers.Supervisor; import org.lumijiez.managers.Supervisor;

View File

@@ -1,12 +1,7 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.group; package org.lumijiez.gui.forms.group;
import org.lumijiez.base.Faculty; import org.lumijiez.base.Faculty;
import org.lumijiez.base.Group; import org.lumijiez.base.Group;
import org.lumijiez.gui.StudentManagementGUI;
import org.lumijiez.gui.util.ComponentDecorator; import org.lumijiez.gui.util.ComponentDecorator;
import org.lumijiez.gui.util.DisplayerManager; import org.lumijiez.gui.util.DisplayerManager;
import org.lumijiez.managers.Supervisor; import org.lumijiez.managers.Supervisor;
@@ -40,7 +35,7 @@ public class EditGroupForm extends JFrame {
setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18)); // NOI18N titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18));
titleLabel.setText("Edit a group"); titleLabel.setText("Edit a group");
nameField.setText("Name..."); nameField.setText("Name...");

View File

@@ -1,10 +1,5 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.group; package org.lumijiez.gui.forms.group;
import org.lumijiez.base.Faculty;
import org.lumijiez.base.Group; import org.lumijiez.base.Group;
import org.lumijiez.base.Student; import org.lumijiez.base.Student;
import org.lumijiez.gui.util.ComponentDecorator; import org.lumijiez.gui.util.ComponentDecorator;
@@ -35,7 +30,7 @@ public class ShowGroupForm extends JFrame {
setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18)); // NOI18N titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18));
titleLabel.setText("Show a group"); titleLabel.setText("Show a group");
groupLabel.setText("Group:"); groupLabel.setText("Group:");
cancelButton.setText("Cancel"); cancelButton.setText("Cancel");

View File

@@ -1,7 +1,3 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.student; package org.lumijiez.gui.forms.student;
import org.lumijiez.base.Faculty; import org.lumijiez.base.Faculty;
@@ -83,7 +79,7 @@ public class AddStudentForm extends JFrame {
setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18)); // NOI18N titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18));
titleLabel.setText("Add a new student"); titleLabel.setText("Add a new student");
submitButton.setText("Submit"); submitButton.setText("Submit");

View File

@@ -1,17 +1,13 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.student; package org.lumijiez.gui.forms.student;
import org.lumijiez.base.Student; import org.lumijiez.base.Student;
import org.lumijiez.gui.StudentManagementGUI;
import org.lumijiez.gui.util.ComponentDecorator; import org.lumijiez.gui.util.ComponentDecorator;
import org.lumijiez.gui.util.DisplayerManager; import org.lumijiez.gui.util.DisplayerManager;
import org.lumijiez.managers.Supervisor; import org.lumijiez.managers.Supervisor;
import org.lumijiez.gui.util.ComboBoxRenderers; import org.lumijiez.gui.util.ComboBoxRenderers;
import javax.swing.*; import javax.swing.*;
import java.awt.*;
import java.awt.event.ActionEvent; import java.awt.event.ActionEvent;
import java.util.Objects; import java.util.Objects;
@@ -33,7 +29,7 @@ public class DeleteStudentForm extends JFrame {
setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE); setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
titleLabel.setFont(new java.awt.Font("sansserif", 0, 18)); // NOI18N titleLabel.setFont(new java.awt.Font("sansserif", Font.PLAIN, 18));
titleLabel.setText("Delete Student"); titleLabel.setText("Delete Student");
ComboBoxRenderers.setStudentRenderer(studentCombo); ComboBoxRenderers.setStudentRenderer(studentCombo);

View File

@@ -1,7 +1,3 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.student; package org.lumijiez.gui.forms.student;
import org.lumijiez.base.Faculty; import org.lumijiez.base.Faculty;

View File

@@ -1,7 +1,3 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.student; package org.lumijiez.gui.forms.student;
import org.lumijiez.base.Grade; import org.lumijiez.base.Grade;

View File

@@ -1,11 +1,6 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.student; package org.lumijiez.gui.forms.student;
import org.lumijiez.base.Student; import org.lumijiez.base.Student;
import org.lumijiez.gui.StudentManagementGUI;
import org.lumijiez.gui.util.ComponentDecorator; import org.lumijiez.gui.util.ComponentDecorator;
import org.lumijiez.gui.util.DisplayerManager; import org.lumijiez.gui.util.DisplayerManager;
import org.lumijiez.managers.Supervisor; import org.lumijiez.managers.Supervisor;

View File

@@ -1,7 +1,3 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.student; package org.lumijiez.gui.forms.student;
import org.lumijiez.base.Student; import org.lumijiez.base.Student;

View File

@@ -1,7 +1,3 @@
/*
* Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
* Click nbfs://nbhost/SystemFileSystem/Templates/GUIForms/JFrame.java to edit this template
*/
package org.lumijiez.gui.forms.student; package org.lumijiez.gui.forms.student;
import org.lumijiez.base.Grade; import org.lumijiez.base.Grade;

View File

@@ -127,67 +127,67 @@ public class FilePicker extends JFrame {
String facultyName; String facultyName;
StudyField specialty; StudyField specialty;
while (true) { while (true) {
line = reader.readLine(); line = reader.readLine();
// Sorry for this
if (line == null) break; if (line == null) break;
if (line.isEmpty()) line = reader.readLine(); if (line.isEmpty()) line = reader.readLine();
name = line.substring("name: ".length()); name = line.substring("name: ".length());
line = reader.readLine(); line = reader.readLine();
// Sorry for this
if (line == null) break; if (line == null) break;
surname = line.substring("surname: ".length()); surname = line.substring("surname: ".length());
line = reader.readLine(); line = reader.readLine();
// Sorry for this
if (line == null) break; if (line == null) break;
email = line.substring("email: ".length()); email = line.substring("email: ".length());
line = reader.readLine(); line = reader.readLine();
// Sorry for this again lol
if (line == null) break; if (line == null) break;
groupName = line.substring("group: ".length()); groupName = line.substring("group: ".length());
line = reader.readLine(); line = reader.readLine();
// Sorry for this again :((
if (line == null) break; if (line == null) break;
facultyName = line.substring("faculty: ".length()); facultyName = line.substring("faculty: ".length());
line = reader.readLine(); line = reader.readLine();
// Please forgive me
if (line == null) break; if (line == null) break;
SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd"); SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd");
birth = dateFormat.parse(line.substring("birthdate: ".length())); birth = dateFormat.parse(line.substring("birthdate: ".length()));
line = reader.readLine(); line = reader.readLine();
// I'm really sorry
if (line == null) break; if (line == null) break;
enrol = dateFormat.parse(line.substring("enroldate: ".length())); enrol = dateFormat.parse(line.substring("enroldate: ".length()));
line = reader.readLine(); line = reader.readLine();
// This is the last one please don't hate me
if (line == null) break; if (line == null) break;
String spec = line.substring("specialty: ".length()); String spec = line.substring("specialty: ".length());
if (StudyField.getEnum(spec) == null) { if (StudyField.getEnum(spec) == null) {
specialty = StudyField.DEFAULT_UNASSIGNED; specialty = StudyField.DEFAULT_UNASSIGNED;
} else { } else specialty = StudyField.getEnum(spec);
specialty = StudyField.getEnum(spec);
}
Faculty faculty; Faculty faculty;
Group group; Group group;
if (sv.getFacultyByName(facultyName) == null) { if (sv.getFacultyByName(facultyName) == null) {
assert specialty != null; assert specialty != null;
faculty = new Faculty(facultyName, specialty.getAbbreviation(), specialty); faculty = new Faculty(facultyName, specialty.getAbbreviation(), specialty);
sv.addFaculty(faculty); sv.addFaculty(faculty);
} else { } else faculty = sv.getFacultyByName(facultyName);
faculty = sv.getFacultyByName(facultyName);
}
if (sv.getGroupByName(groupName, faculty) == null) { if (sv.getGroupByName(groupName, faculty) == null) {
group = new Group(groupName); group = new Group(groupName);
sv.addGroup(group, sv.getFacultyByName(facultyName)); sv.addGroup(group, sv.getFacultyByName(facultyName));
} else { } else group = sv.getGroupByName(groupName, faculty);
group = sv.getGroupByName(groupName, faculty);
}
System.out.println(name + "\n" + surname+ "\n" + email+ "\n" + group.getName()+ "\n" + faculty.getName()+ "\n" + birth+ "\n" + enrol);
sv.addStudent(name, surname, email, group, faculty, birth, enrol); sv.addStudent(name, surname, email, group, faculty, birth, enrol);
} }