Daniel #12

2023-09-30T19:28:33Z

bytegrip commented

2023-09-30 19:28:33 +00:00

(Migrated from github.com)

Implemented controllers, services and repositories for all entities.

Removed dead code.

Getter and setter cleanup using lombok.Data

Implemented controllers, services and repositories for all entities. Removed dead code. Getter and setter cleanup using lombok.Data

roman-gherman (Migrated from github.com) reviewed 2023-09-30 19:28:33 +00:00

mirrerror (Migrated from github.com) reviewed 2023-09-30 19:28:33 +00:00

huntrese (Migrated from github.com) reviewed 2023-09-30 19:28:33 +00:00

strdr4605 (Migrated from github.com) reviewed 2023-09-30 19:28:33 +00:00

gitguardian[bot] commented

2023-09-30 19:28:37 +00:00

(Migrated from github.com)

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
8295187	MariaDB Credentials	`f235921744`	src/main/resources/application.properties	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

#### ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request. Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components. <details> <summary>🔎 Detected hardcoded secret in your pull request</summary> | GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [8295187](https://dashboard.gitguardian.com/incidents/8295187?occurrence=116452937) | MariaDB Credentials | f235921744f66e7fb2a659819a5405243a3273b3 | src/main/resources/application.properties | [View secret](https://github.com/lumijiez/ExpenseTrackerFAF/commit/f235921744f66e7fb2a659819a5405243a3273b3#diff-54eeffbae371fcd1398d4ca5e89a1b8118208b7bb2f8ddf55c1aa2f7d98ab136R4) | </details> <details> <summary>🛠 Guidelines to remediate hardcoded secrets</summary> 1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/mariadb_assignment_attached_port#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation. </details> --- 🦉 [GitGuardian](https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&utm_source=github&utm_campaign=cr1) detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. Our GitHub checks need improvements? [Share your feedbacks](https://050127dayho.typeform.com/to/KmeAPTMk)!

DmitriiKaban (Migrated from github.com) reviewed 2023-09-30 19:56:24 +00:00

DmitriiKaban (Migrated from github.com) left a comment

I can suggest adding validation to the fields in the model package, like @Email for String email.
Also, you should remove the MainController.java file.
application.properties should not be in the repository.

I can suggest adding validation to the fields in the model package, like @Email for String email. Also, you should remove the MainController.java file. application.properties should not be in the repository.

bytegrip commented

2023-09-30 20:04:32 +00:00

(Migrated from github.com)

I can suggest adding validation to the fields in the model package, like @Email for String email.
Also, you should remove the MainController.java file.
application.properties should not be in the repository.

Good idea, will implement that in the next commits.

> I can suggest adding validation to the fields in the model package, like @Email for String email. > Also, you should remove the MainController.java file. > application.properties should not be in the repository. > Good idea, will implement that in the next commits.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: byte/expensetracker#12